Repository navigation
Fix/webhook ssrf - #918
Merged
Merged
Fix/webhook ssrf#918
Conversation
zwfxxxxx
force-pushed
the
fix/webhook-ssrf
branch
from
October 16, 2026 07:08
5e8e728 to
5ab5da0
Compare
seafile-dev
reviewed
Oct 16, 2026
seafile-dev
left a comment
There was a problem hiding this comment.
结论:实现符合分析文档,存在一项测试接入警告,详见行内评论。
阻塞问题:未发现已复现的 SSRF 绕过或其他阻塞实现缺陷。
警告:新增 SSRF 回归测试尚未接入当前 GitHub Actions 测试入口;建议将该测试模块加入 CI,使后续安全回归能够阻止合并。
验证:Python 3.12.3、Requests 2.32.5、urllib3 2.6.3 下,新增的 16 项测试在隔离部署配置后全部通过,包括真实本地 HTTP/TLS、原域名 SNI/证书校验、禁止重定向、IP 固定、私网拒绝和 worker 失败处理。Redis/数据库交互使用测试内 mock,未执行完整部署集成测试。
设计约束已落实:发送前重新解析且拒绝任一非公网结果,连接已校验 IP,保留原域名 TLS 校验,禁止重定向;正常通知正文和签名保持兼容。应与 dtable-web #6359 配套发布。
| from dtable_events.webhook.webhook import Webhooker | ||
|
|
||
|
|
||
| class WebhookDestinationTest(TestCase): |
There was a problem hiding this comment.
[Warning] 新增安全测试未接入 CI
影响:当前 Actions 仅调用 dtable_events/tests/test.sh test,该入口直接执行 sql/sql_test.py,没有发现或导入本模块。因此这些私网拦截、DNS 重绑定和重定向回归测试即使失败,也不会使现有 CI 失败。
建议修复:在现有 CI 环境初始化后显式执行 python -m unittest dtable_events.webhook.tests,或将该模块纳入统一测试入口,并确认失败状态会传递给 Actions。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.