Repository navigation
bugfix - #919
Open
SailingBoat762 wants to merge 1 commit into
Open
bugfix#919SailingBoat762 wants to merge 1 commit into
SailingBoat762 wants to merge 1 commit into
Conversation
…_excel instead of returning early
seafile-dev
reviewed
Oct 26, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
结论：非阻塞意见。地理位置文本过滤已使用 DISPLAYGEO，查询结果仍保留原地理位置列；未发现配套新版本共同运行时的确定性功能缺陷。
阻塞问题：无。
警告：临时文件命名变更不兼容新旧服务混跑，详见行内评论。请将两个服务的切换和旧任务处理纳入发布门禁。
验证：隔离应用启动依赖后，当前 SQL 测试 6 项通过；相同测试针对 merge-base SQL 实现出现 7 个地理位置断言失败，其他断言无错误。真实 XLSX 写入/读取验证行政地址、经纬度、国家及空值列保留；组合执行实际导出函数和 web 下载方法，新/新与旧/旧返回 200，两种新旧混合均返回 404。传输、元数据及权限查询使用替身，不代表真实数据库、鉴权中间件或部署端到端验证。当前 build 检查成功。未提供设计文档。
| sheet_name = table_name + ('_' + view_name if view_name else '') | ||
| sheet_name = escape_sheet_name(sheet_name) | ||
| excel_name = name + '_' + table_name + ('_' + view_name if view_name else '') + '.xlsx' | ||
| excel_name = task_id + '.xlsx' |
There was a problem hiding this comment.
[Warning] 新旧服务混跑会导致导出下载失败
影响：这里改为 task_id.xlsx，配套 web PR 同时切换读取路径；组合执行实际导出函数及下载方法，新 events/旧 web、旧 events/新 web 都返回 404，新/新和旧/旧均为 200。滚动发布期间的新任务，以及切换前已生成的旧文件，都可能显示导出成功却无法下载，大数据导出也同步更换了命名。
建议修复：补充停止接单、排空并处理旧导出任务后原子切换两个服务的发布步骤；若必须滚动发布，则增加安全的过渡期双写/兼容读取，不能只规定某一服务先发布。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.