Improve instance management - #1
Merged
Merged
Conversation
saiful-semantic
commented
Mar 25, 2026
saiful-semantic
commented
Contributor
- Make containers default instance type
- Make swap optional and remove from containers
- Fix jump-user deleting on instance delete
- Detect hardware virtualization support and disable VM creation
- Make jump-user based on instance name and validate
- Add integration and service tests
Add ContainerDefaultSettings model and integrate container-specific settings into instance creation. Updates settings page with new container configuration tab and adds container image filtering.
- Use instance name as username for jump users instead of generic VM settings - Add validation to prevent conflicts with existing system users before instance creation - Update SSH config template to use instance-specific jump-host names - Return error if jump user already exists rather than updating keys
Add integration tests for instance deletion and unit tests for jump user service to improve test coverage
Add /api/vm-support endpoint to check if the system supports LXD virtual machines. Includes client-side JavaScript to disable VM options in the UI when virtualization is not supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.