Fix #1516 - Swap ULID implementation#1518
Open
ricardozanini wants to merge 2 commits into
Open
Conversation
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the impl module to replace the previously used ULID generator with ulid-creator, aligning with Issue #1516’s goal of moving away from an unmaintained, contention-prone ULID implementation.
Changes:
- Swap the ULID dependency from
de.huxhorn.sulky.ulidtocom.github.f4b6a3:ulid-creator. - Update
MonotonicUlidWorkflowInstanceIdFactoryto generate IDs usingUlidFactory. - Add a JUnit test to validate ULID format and basic uniqueness for workflow instance IDs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| impl/core/src/main/java/io/serverlessworkflow/impl/MonotonicUlidWorkflowInstanceIdFactory.java | Switches runtime ULID generation to ulid-creator’s monotonic factory. |
| impl/pom.xml | Replaces the managed ULID dependency and introduces the new version property. |
| impl/core/pom.xml | Updates module dependency to ulid-creator. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/WorkflowInstanceIdTest.java | Adds coverage to ensure generated workflow instance IDs match ULID expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1516