Skip to content

html5ever: avoid unnecessary attribute clone in TreeBuilder::insert_element. #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdm merged 3 commits into from
Aug 8, 2026
Merged

html5ever: avoid unnecessary attribute clone in TreeBuilder::insert_element. #766

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad725e8
refactor(tree-builder): avoid unnecessary attribute clone in `TreeBui…
niklak Aug 5, 2026
9958c09
fix stylistic nits -- apply suggestions from code review
niklak Aug 6, 2026
65af428
Merge branch 'main' into refactor/tree-builder-insert-element
niklak Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions html5ever/src/tree_builder/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,14 +1370,6 @@ where
declare_tag_set!(listed = [form_associatable] - "img");

// Step 7.
let qname = QualName::new(None, ns, name);
let elem = create_element_with_flags(
&self.sink,
qname.clone(),
attrs.clone(),
had_duplicate_attributes,
);

let insertion_point = self.appropriate_place_for_insertion(None);
let (node1, node2) = match insertion_point {
InsertionPoint::LastChild(ref p) | InsertionPoint::BeforeSibling(ref p) => {
Expand All @@ -1390,14 +1382,20 @@ where
};

Comment thread
niklak marked this conversation as resolved.
// Step 12.
if form_associatable(qname.expanded())
let qname = QualName::new(None, ns, name);
let form_is_associatable = form_associatable(qname.expanded())
&& self.form_elem.borrow().is_some()
&& !self.in_html_elem_named(local_name!("template"))
&& !(listed(qname.expanded())
&& attrs
.iter()
.any(|a| a.name.expanded() == expanded_name!("", "form")))
{
.any(|a| a.name.expanded() == expanded_name!("", "form")));

// By checking whether the form is associatable first, then creating the element
// we can avoid cloning the attributes.
let elem = create_element_with_flags(&self.sink, qname, attrs, had_duplicate_attributes);

if form_is_associatable {
let form = self.form_elem.borrow().as_ref().unwrap().clone();
self.sink
.associate_with_form(&elem, &form, (&node1, node2.as_ref()));
Expand Down