feat: removed debugger visualizer + tests - #420
Merged
Conversation
alejandro-vaz
marked this pull request as ready for review
August 20, 2026 10:14
emilio
approved these changes
Aug 20, 2026
emilio
left a comment
emilio
left a comment
Member
There was a problem hiding this comment.
I think given this feature broke, nobody noticed except for #415, and I can't test it, it seems fine to remove.
We could keep the natvis file I guess, but I have very low confidence it has stayed correct with the change to union and so on.
Author
|
apparently there was support for a workflow test that ran the debugger visualizer case with the union feature which probably also failed but never got to run on the logs because the one without the union feature failed first |
Author
|
PR is ready to be merged |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the
debugger_visualizerfeature and test causing #413 and #415.The test case was previously commented out to pass tests.
Feature is no longer being maintained.
Docs generate successfully with
cargo doc --all-features.Removed feature from
Cargo.toml.Before merging
Figure out whether we really want to remove the feature or only the testing for it (i.e. assume the
.natvisscript written long ago is correct).