Fix warnings - #431
Open
zachs18 wants to merge 2 commits into
Open
Conversation
alejandro-vaz
approved these changes
Aug 21, 2026
Contributor
alejandro-vaz
suggested changes
Aug 22, 2026
Contributor
There was a problem hiding this comment.
I think the clear API boundary here is not spec_traits.rs, I'd honestly say it is:
specialization.rs- with all the methods that involve specialization
lib.rswith a conditional compilation flag that includesspecialization.rsonly when the feature is enabled- the normal methods on
SmallVeconlib.rsthat also have specialization have a conditional compilation flag of feature disabled
| (unsafe {&raw const self.inline}) as *mut T | ||
| // pointer to it. reading it would be UB potentially, but for that downstream | ||
| // unsafe is required. This is no longer unsafe as of Rust 1.92.0. | ||
| #[allow(unused_unsafe, reason = "requires unsafe in MSRV 1.83.0")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
unused_unsafewarnings on Rust >=1.92.0 by adding#[allow]s since the relevant code is not safe in the MSRV 1.83.0 declared in Cargo.toml (this could also be fixed by bumping MSRV to 1.92.0 and removing theunsafeblocks).Fixes specialization syntax future-compatibility-warnings by moving the
spec_traitsmodule to a file (cc #427 ).