Skip to content

fix: allow application-specific SES tags #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glitchedmob merged 1 commit into from
Aug 24, 2026
Merged

fix: allow application-specific SES tags #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 13 additions & 23 deletions src/tf/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,13 +214,11 @@ resource "aws_iam_role_policy" "github_actions_terraform_ses" {
locals {
application_ses_senders = {
methodconf = {
application = "methodconf.com"
domain = "methodconf.com"
path = "methodconf"
policy_name = "MethodConfSESSender"
}
sgf_dev = {
application = "sgf.dev"
domain = "sgf.dev"
path = "sgf-dev"
policy_name = "SgfDevSESSender"
Expand All @@ -237,7 +235,7 @@ resource "aws_iam_policy" "application_ses_sender" {

name = each.value.policy_name
path = "/applications/${each.value.path}/"
description = "Allow ${each.value.application} applications to send email from their tagged address"
description = "Allow ${each.value.domain} applications to send email from their tagged address"

policy = jsonencode({
Version = "2012-10-17"
Expand Down Expand Up @@ -276,12 +274,14 @@ resource "aws_iam_role_policy" "github_actions_terraform_application_ses_iam" {
Resource = "arn:aws:iam::${data.aws_caller_identity.current.account_id}:user/applications/${application.path}/*"
Condition = {
StringEquals = {
"aws:RequestTag/Application" = application.application
"aws:RequestTag/ManagedBy" = "OpenTofu"
"aws:RequestTag/ManagedBy" = "OpenTofu"
}
StringLike = {
"aws:RequestTag/SESFromAddress" = "*@${application.domain}"
}
Null = {
"aws:RequestTag/Application" = "false"
}
"ForAllValues:StringEquals" = {
"aws:TagKeys" = [
"Application",
Expand All @@ -305,12 +305,14 @@ resource "aws_iam_role_policy" "github_actions_terraform_application_ses_iam" {
"iam:PolicyARN" = local.application_ses_policy_arns[key]
}
StringEquals = {
"iam:ResourceTag/Application" = application.application
"iam:ResourceTag/ManagedBy" = "OpenTofu"
"iam:ResourceTag/ManagedBy" = "OpenTofu"
}
StringLike = {
"iam:ResourceTag/SESFromAddress" = "*@${application.domain}"
}
Null = {
"iam:ResourceTag/Application" = "false"
}
}
}],
[for key, application in local.application_ses_senders : {
Expand All @@ -332,12 +334,14 @@ resource "aws_iam_role_policy" "github_actions_terraform_application_ses_iam" {
Resource = "arn:aws:iam::${data.aws_caller_identity.current.account_id}:user/applications/${application.path}/*"
Condition = {
StringEquals = {
"iam:ResourceTag/Application" = application.application
"iam:ResourceTag/ManagedBy" = "OpenTofu"
"iam:ResourceTag/ManagedBy" = "OpenTofu"
}
StringLike = {
"iam:ResourceTag/SESFromAddress" = "*@${application.domain}"
}
Null = {
"iam:ResourceTag/Application" = "false"
}
}
}],
[for key, application in local.application_ses_senders : {
Expand All @@ -354,20 +358,6 @@ resource "aws_iam_role_policy" "github_actions_terraform_application_ses_iam" {
}
}
}],
[for key, application in local.application_ses_senders : {
Sid = "RejectInvalid${replace(title(key), "_", "")}ApplicationTags"
Effect = "Deny"
Action = "iam:TagUser"
Resource = "arn:aws:iam::${data.aws_caller_identity.current.account_id}:user/applications/${application.path}/*"
Condition = {
Null = {
"aws:RequestTag/Application" = "false"
}
StringNotEquals = {
"aws:RequestTag/Application" = application.application
}
}
}]
)
})
}