Reduce shared memory usage in decode scheduling metadata kernel - #12
Open
FrankMinions wants to merge 1 commit into
Open
Reduce shared memory usage in decode scheduling metadata kernel#12FrankMinions wants to merge 1 commit into
FrankMinions wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_mla_metadata_kernelfrom5*b+1to3*b+1by dropping redundantfirst_block_idx/last_block_idxbuffers.first_token_idxis always 0,first_block_idxis always 0 andlast_block_idx + 1equalsnum_blocks, so block range bounds can be derived fromnum_blocksand the local split offset (now_block) instead of being cached in shared memory.begin_block_idx/end_block_idx/is_last_req_splittedcomputation accordingly; scheduling semantics are unchanged.Motivation
The decode scheduling metadata kernel previously reserved shared memory for five
intarrays of size roughly proportional to batch size. Two of those arrays were redundant given the current dense/sparse indexing assumptions (first_token_idx == 0). Removing them lowers shared-memory pressure for large batches and simplifies the kernel. Especially on H200, a largechunk-prefill-sizecan cause a bottleneck in shared-memory allocation, leading to a fallback toget_mla_metadata_kernel_low_smem.