Skip to content

refactor: subprocess_read_stdout parameter to size_t in linux cases #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
to-s wants to merge 1 commit into from
Closed

refactor: subprocess_read_stdout parameter to size_t in linux cases #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion subprocess.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2022,9 +2022,9 @@ int subprocess_terminate(struct subprocess_s *const process) {
#endif
}

#if defined(_WIN32)
unsigned subprocess_read_stdout(struct subprocess_s *const process,
char *const buffer, unsigned size) {
#if defined(_WIN32)
void *handle;
unsigned long bytes_available = 0;
unsigned long bytes_read = 0;
Expand Down Expand Up @@ -2074,6 +2074,8 @@ unsigned subprocess_read_stdout(struct subprocess_s *const process,

return SUBPROCESS_CAST(unsigned, bytes_read);
#else
unsigned subprocess_read_stdout(struct subprocess_s *const process,
char *const buffer, size_t size) {
const int fd = fileno(process->stdout_file);
const ssize_t bytes_read = read(fd, buffer, size);

Expand Down