Repository navigation
Make the item type picker readable - #12
Merged
Merged
Conversation
Every type added since the picker was built made it narrower. At seven columns the labels were 10px and truncated, so "Secure Note" arrived as "Secure No…" and the icons were carrying meaning the words were meant to. Four columns across two rows instead, at a legible size. The tiles have a fixed height because "Secure Note" wraps to two lines and would otherwise make its entire row taller than the one beneath it. Field spacing went from 3.5 to 4: at the tighter value each label sat close enough to the control above it to read as attached to the wrong field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every type added since the picker was built made it narrower. At seven columns the labels were 10px and truncated — "Secure Note" arrived as "Secure No…", and the icons were carrying meaning the words were supposed to.
Four columns across two rows, at a legible size. Tiles have a fixed height because "Secure Note" wraps to two lines and would otherwise make its whole row taller than the one beneath it.
Field spacing 3.5 → 4: at the tighter value each label sat close enough to the control above it to read as belonging to the wrong field.