Repository navigation
README and roadmap: every item type has its own fields - #16
Merged
Merged
Conversation
… missing The README's limitations list still said cards and identities "store fields but have no dedicated editor". They have one, so that line described a program that no longer exists. Cards, identities and documents get feature rows, with the part of each that is not obvious: a card's issuer is read from its number and checked against Luhn as it is typed, and a document deliberately does not store the file. The roadmap's "item types beyond logins" entry is removed rather than ticked, and duplicate detection moves up to take its place. 936 unit tests, 43 end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The limitations list still said cards and identities store fields but have no dedicated editor. They have one, so that line described a program that no longer exists.
Cards, identities and documents get feature rows, each with the part that is not obvious — a card's issuer is read from its number and Luhn-checked as it is typed, and a document deliberately does not store the file.
The roadmap's item types beyond logins entry is removed rather than ticked, and duplicate detection moves up to take its place.