Repository navigation
Conversation
Asked whether saving a password from a website still worked after the item form was rebuilt. It did — but only the end-to-end test asserting the prompt appears covered it, and "the prompt appeared" is not "the password was saved". Two tests now cover what actually matters: a credential submitted on a page becomes a usable login and is offered back to the site it came from, and it carries a revision counter. The second is the subtle one — an entry created by the save prompt without a counter would look unchanged to every future merge and never propagate to another device. The form and the save prompt are different paths, which is exactly why a change to one is the kind that quietly takes the other with it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asked whether saving a password from a website still worked after the item form was rebuilt. It did — but the only coverage was an end-to-end test asserting the prompt appears, and "the prompt appeared" is not "the password was saved".
Two tests now cover what matters: a credential submitted on a page becomes a usable login and is offered back to the site it came from, and it carries a revision counter.
The second is the subtle one — an entry created by the save prompt without a counter would look unchanged to every future merge and never propagate to another device.
The form and the save prompt are different code paths, which is exactly why a change to one is the kind that quietly takes the other with it.