fix(db): take ShipKit's typed database helper; declare @types/react-dom - #110
Merged
Merged
Conversation
safeDbExecute in Bones was untyped, so ShipKit's admin route handler (shipped by the admin item) failed typecheck after install. The file is ShipKit's byte for byte now. @types/react-dom was only ever hoisted; pnpm does not expose it, so a shipped component that imports react-dom had no types.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safeDbExecute in Bones was untyped, so ShipKit's admin route handler
(shipped by the admin item) failed typecheck after install. The file is
ShipKit's byte for byte now. @types/react-dom was only ever hoisted;
pnpm does not expose it, so a shipped component that imports react-dom
had no types.
Found by the smoke sweep (admin, dashboard). Typecheck clean.