ci: add Windows unit test job - #394
Conversation
pull-request-size
Bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a Windows CI job to run Go unit tests alongside the existing unit-test workflow.
Changes:
- Introduces a
test-unit-windowsjob running onwindows-latest - Sets up Go and runs
go testwith race detection and coverage on Windows
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: preko-p <278021202+preko-p@users.noreply.github.com>
c14a2ee to
a7d30d4
Compare
IrvingMg
left a comment
IrvingMg
left a comment
There was a problem hiding this comment.
Thanks for contribution.
Have you had a chance to run the unit tests on Windows? Would be good to confirm they actually pass before we add a check that might be broken.
| check-latest: true | ||
|
|
||
| - name: Run Unit Tests | ||
| run: go test -mod=vendor -race -cover ./cmd/shp/... ./pkg/... |
There was a problem hiding this comment.
Could we use make test-unit here as well?
Summary
test-unit-windowsGitHub Actions job for Windows unit coveragetest-unitjob and status-check name unchangedmake test-unitcommand directly withgo test -mod=vendor -race -cover ./cmd/shp/... ./pkg/...so the Windows job does not depend onmakeFixes #64.
Testing
docker run --rm -v "$PWD":/workspace -w /workspace golang:1.25 go test -mod=vendor -race -cover ./cmd/shp/... ./pkg/...docker run --rm -v "$PWD":/workspace -w /workspace golang:1.25 sh -c 'GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go build -mod=vendor ./cmd/shp/...'git diff --checkNotes
The actual Windows unit test execution is intentionally left to upstream GitHub Actions. The existing Linux
test-unitjob remains unchanged so current branch protection/check names are not disturbed; maintainers can decide whether to make the new Windows job required.This PR was prepared with AI assistance and reviewed before submission.