Repository navigation
fix(1.2): Correct zoom values of link and service attributes - #189
Open
MichaelKreil wants to merge 1 commit into
Open
MichaelKreil wants to merge 1 commit into
MichaelKreil wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #184, this should be included in version 1.2.
Problem:
Some features in the
streetslayer can only be distinguished by an attribute, but the schema lists that attribute for a higher zoom level than the feature itself. Between these two zoom levels, features end up in tiles with the wrong attribute because it is missing.Link roads (
kind=motorway/trunk/primary/secondary/tertiary):linkRailways with
service=*(kind=rail/narrow_gauge):serviceAs a result, motorway links are drawn as stumps of main roads below z11. At z10, railway yards, sidings, and spurs are drawn at main-line weight, and then switch to service styling at z11.
Change
In schema/1.2.md, layer streets:
link: zoom11+->5+, the lowest zoom where any link road appearsservice: zoom11+->10+, the lowest zoom level at which railways withservice=*appearImpact on implementations
These changes affect the data, not just the documentation. TileMaker and the OSM2PGSQL Themepark
shortbread_v1theme split the layer intostreets_low(z5–10, onlykindandrail),streets_medandstreets. They need to addlinkandserviceto thestreets_lowwrites. In TileMaker, this involves a two-line change. The Planetiler custommap sample requires a matching zoom change.What this does not fix
This PR is not a "hot fix" for the 1.0 and 1.1 specifications. Tiles built against these specifications will still contain incorrect data with erroneous attributes at certain zoom levels.