Skip to content

Subscribe to Japanese writing skills - #772

Open
shunk031 wants to merge 1 commit into
mainfrom
feat/yomiyasu-writing-skill
Open

shunk031 wants to merge 1 commit into
mainfrom
feat/yomiyasu-writing-skill

Conversation

@shunk031

@shunk031 shunk031 commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Motivation

The related writing router selects tanteki and yomiyasu, so both skills need to be present in the shared installation source.

Changes

  • Add iwasa-kosui/tanteki:tanteki and nanaism/yomiyasu:yomiyasu to the common skills allowlist.
  • This updates source configuration only; it does not install the skills or apply dotfiles. The router guides skill selection but does not guarantee runtime isolation.
  • Related router change: Add Japanese writing skill router skills#92

Testing

  • make validate passed.
  • bash -n and shfmt checks passed for install/common/skills.sh.
  • git diff --check passed.
  • SKIP=shuhari-eval-instructions prek run --files install/common/skills.sh passed; schema and Markdown hooks had no matching files, and the live evaluation hook was skipped as authorized.

Co-authored-by: Codex <noreply@openai.com>
@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.00%. Comparing base (58fcdfe) to head (0e5061b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
+ Coverage   80.86%   81.00%   +0.14%     
==========================================
  Files          25       25              
  Lines        1113     1116       +3     
==========================================
+ Hits          900      904       +4     
+ Misses        213      212       -1     
Flag Coverage Δ
macos 41.66% <ø> (ø)
rockylinux 81.12% <100.00%> (+0.14%) ⬆️
ubuntu 78.06% <100.00%> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant