fix: tolerate concurrent queue creation - #221
Open
obckelbley wants to merge 1 commit into
Open
obckelbley wants to merge 1 commit into
obckelbley wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
grantQueueConfig() currently performs getQueue() followed by createNewQueue(). Two replicas starting against a new queue can both observe that it is absent, then race on the unique queue name. One succeeds and the other fails startup with a duplicate-key error even though the desired queue now exists.
After a failed insert, this change re-reads the queue. If it now exists, the operation has reached its intended postcondition and returns (or reconciles) that row. If it does not exist, the original error is rethrown. Keeping the recovery in grantQueueConfig makes it backend-neutral rather than matching database-specific duplicate error shapes.
Validation