Repository navigation
Maintenance: fix duration bugs, update dependencies, modernise CI - #16
Merged
Merged
Conversation
Bug fixes (issues #4 and #6): - Fix SLA time on the final day being skipped when the end time-of-day is earlier than the start time-of-day, by anchoring the daily iteration at the start of day in both SLA::get_current_duration and Agenda\Weekly::toPeriods - Add regression tests covering both reported scenarios Dependencies: - Require PHP ^8.3 (8.1/8.2 are EOL) - Update to Carbon ^3, illuminate/collections ^11|^12|^13 - Upgrade dev tooling to Pest ^4, PHPStan ^2, Pint ^1.30, spatie/invade ^2, spatie/pest-plugin-test-time ^2.2 - Update npm dependencies (vitepress 1.6.4, tailwindcss 4.3.3, vue 3.5.41) - Fix broken test-coverage composer script (missing space) Static analysis & style: - Add phpstan.neon.dist (referenced by CI but missing) and fix all 50 level-8 findings, including latent bugs (Weekly::addTimePeriods over-flattening) and dead code (getPeriodsForDay was never defined) - Migrate phpunit.xml to the current schema CI: - Modernise GitHub Actions (checkout@v7, setup-node@v7, pint action replaced with direct tooling, gh-pages deploy via first-party actions) - Test matrix now covers PHP 8.3, 8.4, 8.5
This was referenced Aug 15, 2026
Closed
Closed
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full maintenance pass: fixes the two open bug reports, updates all dependencies to current majors, adds static analysis that was referenced but missing, and modernises CI.
Bug fixes — closes #4 and #6
Both issues reported SLA durations missing time on the final day (e.g.
16:58 Fri → 09:01 Monreturned 2 min instead of 3 min 1 sec). Root cause: the per-day iteration inSLA::get_current_duration()and the agenda period generation inAgenda\Weekly::toPeriods()were anchored at the start time-of-day, so when the end time-of-day was earlier than the start time-of-day, the end date was never iterated and its SLA time was dropped.src/SLA.php— anchor the daily iteration atstartOfDay()and keep the real subject bounds separate for the overlap min/max logicsrc/Agenda/Weekly.php— same day-anchoring fix for agenda period generationtests/SLATest.php— regression tests for both reported scenariosVerified: issue #4 now returns 379 min (was 77), issue #6 returns 181 s (was 120).
Dependencies
^8.3(8.1 is EOL, 8.2 EOL Dec 2026) — unlocks the current toolchainnesbot/carbon^2→^3illuminate/collections→^11|^12|^13pestphp/pest^1→^4(PHP 8.4/8.5 compatible — Pest 1 crashes on 8.5),phpstan/phpstan^1→^2,laravel/pint^1.30,spatie/invade^2,spatie/pest-plugin-test-time^2.2; removed directphpunit/phpunit(bundled by Pest)test-coveragecomposer script (missing space:pest--coverage-clover)Static analysis & style
phpstan.neon.dist(CI workflow referenced it but it didn't exist) and fixed all 50 level-8 findings, including a latent bug (Weekly::addTimePeriodsover-flattened period pairs) and dead code calling a never-defined methodphpunit.xmlto the current schema (PHPUnit 12)CI
8.1–8.4→8.3, 8.4, 8.5actions/checkout@v7,actions/setup-node@v7,actions/github-script@v9, plusshivammathur/setup-phpand GitHub'sdependabot/fetch-metadata; removedpeaceiris/actions-gh-pages,laravel-pint-action,git-auto-commit-action,changelog-updater-action,ramsey/composer-install(replaced with direct tooling)gh-pagesvia plain gitHousekeeping
docs/guide/getting_started.md— requirements updated to PHP 8.3