Phase-1 follow-up: Avalonia interlinear editor (Words Analyses)#965
Draft
johnml1135 wants to merge 1 commit into
Draft
Phase-1 follow-up: Avalonia interlinear editor (Words Analyses)#965johnml1135 wants to merge 1 commit into
johnml1135 wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
johnml1135
force-pushed
the
phase1-followup-interlinear
branch
from
17bd535 to
5120ef6
Compare
johnml1135
force-pushed
the
phase1-base
branch
2 times, most recently
from
3a905c6 to
b423a19
Compare
johnml1135
force-pushed
the
phase1-followup-interlinear
branch
from
5120ef6 to
3c5893e
Compare
johnml1135
force-pushed
the
phase1-base
branch
3 times, most recently
from
e9cdaa0 to
c37eb02
Compare
johnml1135
added a commit
that referenced
this pull request
Jul 3, 2026
Verified the stacked follow-up PRs this base PR's description promises actually exist and are correctly chained: phase1-followup-interlinear (#965) -> phase1-followup-rule (#966) -> phase1-followup-table (#967), all open/draft. The gating comments explaining why the browse table and ChorusNotesPlugin are inert said "a follow-up PR" generically -- name phase1-followup-table specifically (matching the sibling comment in LexicalEditSurfaceRegistry.cs, which already names avalonia-interlinear- editor/avalonia-rule-formula-editor per tool). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
johnml1135
force-pushed
the
phase1-followup-interlinear
branch
2 times, most recently
from
d6003e4 to
c937d8b
Compare
Restore the interlinear surface on top of phase1-base and activate it: - add back the 11 interlinear files (InterlinearRegionEditor + analysis model + projector/write-back + plugin + their tests, incl. the FwAvalonia model and Visual tests) - restore the InterlinearSlicePlugin registration in RegionEditorPlugins - restore the interlinear class name + resolve assertion in the burn-down census - FLIP: register "Analyses" in LexicalEditFeatureCatalog (with new display-name/description strings), so it flows into the catalog- sourced DefaultSupportedTools and the Words Analyses detail editor resolves to Avalonia under UIMode=New; removed from Phase1FollowUpSurfaceTools - add the "Analyses" TestCase back to RegisteredRecordEditTools_ResolveToAvalonia The browse "Analyses" list pane stays inert (table follow-up territory). Rebased onto the squashed phase1-base (post PR #964 review): the base PR had since refactored tool registration to be catalog-driven, so this flip now also adds a "Words Analyses" row to the Tools->Options "Manage Individual Features" dialog under UIMode=New. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
johnml1135
force-pushed
the
phase1-followup-interlinear
branch
from
c937d8b to
bebe347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase-1 follow-up: Avalonia interlinear editor (Words → Analyses)
Stacked on #964 (base). Restores and activates the native Avalonia interlinear editor for the Words → Analyses morph-bundle detail pane.
InterlinearSlicePlugin, tests).RegionEditorPluginsand the burn-down census entry."Analyses"inLexicalEditFeatureCatalog(with new display-name/description strings), so it flows into the catalog-sourcedDefaultSupportedToolsand the editor resolves to Avalonia underUIMode=New(default still Legacy); removed fromPhase1FollowUpSurfaceTools.Note: since this branch was rebased onto the squashed base PR, "flip" now means a catalog entry rather than a hardcoded array edit — as a side effect, this also adds a new "Words Analyses" row to the Tools→Options "Manage Individual Features" dialog (under "Other record types"), visible under
UIMode=New.Verification: build green; census +
RegisteredRecordEditTools("Analyses")+ interlinear suites all passing (FwAvaloniaTests846/846,xWorksTests1664/1666, 2 pre-existing skips). Review after the base PR.This change is