Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the set classification observed when importing an Aster-converted
model into LIMIT, compared against the reference Abaqus model of the same
structure.
Two distinct root causes:
clean_name()stripped every underscore, so the prefixes LIMIT matchesliterally (
PROF_,SW_) were destroyed and their sets landed inOther Nsets / Other Elsets instead of Profile Sets and Solid Weld
Generation Elsets.
_write_sections()wrote a*Sectionfor every active elset, and anelset with a section becomes a Property Set on import. The industrial
model came in with 35 Property Sets against 11 on the Abaqus side.
Only
solset*/surfset*groups actually carry a material/thickness.Both fixes fall back to the previous behaviour when the convention is
absent, so models that do not follow it are unaffected.
Also adds
--limit-prefixes/--property-prefixesto override bothconventions, and a warning listing the elsets left without a
*Section(otherwise they reach LIMIT with no material or thickness, unnoticed).