chore: migrate TypeScript settings to js/ts namespace - #3717
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds VS Code workspace settings for JavaScript and TypeScript import selection, type-only auto-imports, and the workspace TypeScript SDK. ChangesEditor configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change adds newer VS Code TypeScript setting names while retaining legacy names for compatibility; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
8월 31일 08시 30분 merge 예정입니다. 이전까지 내용 확인 및 의견제시(필요시) 부탁드립니다. |
Description
VSCode changed TypeScript settings prefix from typescript to js/ts.
For example "js/ts.tsdk.path" replaces "typescript.tsdk" .
microsoft/vscode#292934
Since it would be better to maintain compatibility with legacy versions of VS Code, I kept the
typescript.*settings as well.closes TAS-2919
Before submitting the PR, please make sure you do the following
fixes #123).Summary by CodeRabbit