Skip to content

chore: migrate TypeScript settings to js/ts namespace - #3717

Merged
lukekeum merged 2 commits into
mainfrom
hotfix-support-newer-vscode-typescript-settings
Aug 30, 2026
Merged

chore: migrate TypeScript settings to js/ts namespace#3717
lukekeum merged 2 commits into
mainfrom
hotfix-support-newer-vscode-typescript-settings

Conversation

@lukekeum

@lukekeum lukekeum commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Description

VSCode changed TypeScript settings prefix from typescript to js/ts.

For example "js/ts.tsdk.path" replaces "typescript.tsdk" .

microsoft/vscode#292934

Since it would be better to maintain compatibility with legacy versions of VS Code, I kept the typescript.* settings as well.

closes TAS-2919


Before submitting the PR, please make sure you do the following

Summary by CodeRabbit

  • Chores
    • Updated workspace editor settings to improve TypeScript import suggestions and use the project’s configured TypeScript version.

@lukekeum lukekeum self-assigned this Aug 30, 2026
@lukekeum lukekeum added the p1-chore 🧹 Priority 1: 코드 동작에 영향이 없는 수정 label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b10a82c-430d-4849-b9a9-586f284e25d9

📥 Commits

Reviewing files that changed from the base of the PR and between 7669777 and cd772bd.

📒 Files selected for processing (1)
  • .vscode/settings.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The pull request adds VS Code workspace settings for JavaScript and TypeScript import selection, type-only auto-imports, and the workspace TypeScript SDK.

Changes

Editor configuration

Layer / File(s) Summary
TypeScript editor preferences
.vscode/settings.json
VS Code now selects shortest module imports, prefers type-only auto-imports, and uses the workspace TypeScript SDK.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cd772

This localized change adds newer VS Code TypeScript setting names while retaining legacy names for compatibility; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: dlwnsgk529, egg-zz, hjkim24

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR changes only .vscode/settings.json and does not implement the ProgressCard component requested by issue [#123]. Implement the ProgressCard component with the requested fields, or link this PR to an issue that covers the VS Code settings migration.
Out of Scope Changes check ⚠️ Warning The VS Code settings migration is unrelated to the linked issue [#123], which requests a workbook progress card component. Remove the settings migration from this PR, or update the linked issue and submit the progress card work in a separate PR.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: migrating TypeScript settings to the js/ts namespace.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix-support-newer-vscode-typescript-settings

Comment @coderabbitai help to get the list of available commands.

@lukekeum

Copy link
Copy Markdown
Contributor Author

8월 31일 08시 30분 merge 예정입니다. 이전까지 내용 확인 및 의견제시(필요시) 부탁드립니다.

@lukekeum
lukekeum added this pull request to the merge queue Aug 30, 2026
Merged via the queue into main with commit f7930c7 Aug 30, 2026
34 checks passed
@lukekeum
lukekeum deleted the hotfix-support-newer-vscode-typescript-settings branch August 30, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore 🧹 Priority 1: 코드 동작에 영향이 없는 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants