Skip to content

Ack API call removed during poll #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vishnu-m-r wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ack API call removed during poll #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pyconductor/ConductorWorker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ def poll_and_execute(self, taskType, exec_function, domain=None):
time.sleep(float(self.polling_interval))
polled = self.taskClient.pollForTask(taskType, self.worker_id, domain)
if polled is not None:
if self.taskClient.ackTask(polled['taskId'], self.worker_id):
self.execute(polled, exec_function)
self.execute(polled, exec_function)

def start(self, taskType, exec_function, wait, domain=None):
"""
Expand Down
8 changes: 0 additions & 8 deletions pyconductor/conductor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,14 +213,6 @@ def pollForBatch(self, taskType, count, timeout, workerid, domain=None):
print('Error while polling ' + str(err))
return None

def ackTask(self, taskId, workerid):
url = self.makeUrl('{}/ack', taskId)
params = {}
params['workerid'] = workerid
headers = {'Accept': 'application/json'}
value = self.post(url, params, None, headers)
return value in ['true', True]

def getTasksInQueue(self, taskName):
url = self.makeUrl('queue/{}', taskName)
return self.get(url)
Expand Down