Skip to content

docs: clarify macOS old-core health status fallback - #1450

Open
mvanhorn wants to merge 2 commits into
smart-mcp-proxy:mainfrom
mvanhorn:fix/1432-macos-old-core-health-fallback
Open

mvanhorn wants to merge 2 commits into
smart-mcp-proxy:mainfrom
mvanhorn:fix/1432-macos-old-core-health-fallback

Conversation

@mvanhorn

@mvanhorn mvanhorn commented Oct 1, 2026 •

Copy link
Copy Markdown

Description

Fixes #1432

Docs-only change to specs/109-ux-navigation-consistency/contracts/health-vocabulary.md.

The health vocabulary contract said every core that sends no status falls back to the legacy words. That does not match the macOS app. ServerStatusLinePresentation.line(for:) only derives legacy words after two earlier branches fail: a present non-empty health.status, then a present health object with a non-empty summary. So on macOS, an older core that sends a summary such as Connection refused and no status shows that summary as the whole label on the Servers row, the tray server submenu, and the Server Detail header.

The paragraph now describes the three branches in order and names testOldCoreHealthWithoutStatusUsesItsSummary and testOldCoreFallbacksUseLegacyWordsOnlyWithoutHealth as the tests that pin this behavior. No code or tests change.

Verification:

cd native/macos/MCPProxy
swift test --filter ServerStatusLineTests

Executed 13 tests, with 0 failures, confirming the behavior the paragraph now describes.

Testing

  • I have tested these changes locally
  • I have added/updated tests that prove my fix is effective or my feature works
  • All existing tests pass

The full suite was not run, since only a markdown file changes.

@mvanhorn
mvanhorn force-pushed the fix/1432-macos-old-core-health-fallback branch from 68f1219 to 15d7113 Compare October 1, 2026 13:42
@Dumbris
Dumbris enabled auto-merge (squash) October 2, 2026 14:54
@Dumbris

Dumbris commented Oct 2, 2026

Copy link
Copy Markdown
Member

Thanks a lot @mvanhorn! The contract now matches ServerStatusLinePresentation.line(for:) exactly, and pointing at the two tests that pin the behavior makes it easy to keep it accurate. Much appreciated — this will merge as soon as CI finishes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Dumbris
Dumbris disabled auto-merge October 2, 2026 15:37
@Dumbris
Dumbris enabled auto-merge (squash) October 2, 2026 15:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow-ups from Spec 109 leftovers review (#1428)

2 participants