Conversation
mvanhorn
force-pushed
the
fix/1432-macos-old-core-health-fallback
branch
from
October 1, 2026 13:42
68f1219 to
15d7113
Compare
Dumbris
enabled auto-merge (squash)
October 2, 2026 14:54
Member
|
Thanks a lot @mvanhorn! The contract now matches |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dumbris
disabled auto-merge
October 2, 2026 15:37
Dumbris
enabled auto-merge (squash)
October 2, 2026 15:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1432
Docs-only change to
specs/109-ux-navigation-consistency/contracts/health-vocabulary.md.The health vocabulary contract said every core that sends no
statusfalls back to the legacy words. That does not match the macOS app.ServerStatusLinePresentation.line(for:)only derives legacy words after two earlier branches fail: a present non-emptyhealth.status, then a presenthealthobject with a non-emptysummary. So on macOS, an older core that sends a summary such asConnection refusedand no status shows that summary as the whole label on the Servers row, the tray server submenu, and the Server Detail header.The paragraph now describes the three branches in order and names
testOldCoreHealthWithoutStatusUsesItsSummaryandtestOldCoreFallbacksUseLegacyWordsOnlyWithoutHealthas the tests that pin this behavior. No code or tests change.Verification:
Executed 13 tests, with 0 failures, confirming the behavior the paragraph now describes.
Testing
The full suite was not run, since only a markdown file changes.