fix: Home estimate label, Get started card, Activity conflict clear and status-coloured health (Spec fix-ux-residuals) - #1467
Merged
Conversation
…d on a fresh instance (Spec fix-ux-residuals)
… and surface blocked attempts (Spec fix-ux-residuals)
…c fix-ux-residuals)
Deploying mcpproxy-docs with
|
| Latest commit: |
4ec9ce7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1a84d918.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-ux-residuals-final.mcpproxy-docs.pages.dev |
F1.1 (confirmed): removing a conflicting server/tool chip, or Clear filters,
with a profile/client/token scope in the URL sent two requests, the first
without the scope. The conflicting URL made toRest() return null, so the scope
dropped out of the request until the router.replace settled and the scope key
changed. profile/client/token do not depend on the server/tool pair, so
Activity now reads them with toRest({ ignoreConflict: true }); the scope key
no longer flips on conflict resolution and the single refetch carries it.
loadActivities() still issues nothing while scopeConflict is set.
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37012258733 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
11 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last open items of the Spec 109 done check, fixed test-first inside the files Spec 109 owns (Home, Activity, Server Detail, macOS Home). There is no backend change, no new dependency and no golden change.
What changes for the user
Web UI Home
mcpproxy attentionstill prints "All clear".Web UI Activity
Web UI Server Detail
macOS app
CLI, REST and MCP are unchanged.
Audit findings
Spec and tests
Spec: specs/109-ux-navigation-consistency (tasks T166 to T171, research D36, spec.md US1-4, FR-051, FR-070, FR-073, url-filter-contract, health-vocabulary, parity row 22, acceptance index, quickstart recipe fix-ux-residuals, docs/web-ui/dashboard.md).
New tests: home-token-savings-estimate, home-getting-started, activity-scope-conflict-clear, activity-blocked-in-calls-view and server-detail-health-status-colour (vitest), and HomeTokenSavingsBadgeTests (XCTest). home-attention was updated to use a configured server. Full vitest, vue-tsc, the frontend build, the full swift test suite and the Spec 109 traceability and parity Go tests pass.
Left for follow-up issues: refused attempts in the default Tool calls view across Web, macOS and CLI together; the "1 calls" label on the profile card (Spec 108); sharing the status-to-tone map and the estimate tooltip; a macOS Home getting-started card.
Refs #1394 (items 1 and 2 are fixed here; the low items stay open).