Repository navigation
CCIP-13038: Adding APTOS tooling to update feeAggregator and withdraw fee tokens - #580
Open
b-gopalswami wants to merge 3 commits into
Open
b-gopalswami wants to merge 3 commits into
b-gopalswami wants to merge 3 commits into
Conversation
product-security-plaid-production
Bot
requested review from
cl-efornaciari and
ilija42
October 7, 2026 14:08
b-gopalswami
requested
a balanced review from Copilot
and removed request for
cl-efornaciari
October 7, 2026 14:08
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Withdrawal amounts are silently ignored, and zero fee-aggregator addresses generate transactions guaranteed to abort.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds Aptos tooling for configuring the OnRamp fee aggregator and withdrawing accumulated fee tokens.
Changes:
- Adds and registers Aptos fee-aggregator operations and adapter sequences.
- Preserves the existing allowlist admin when updating dynamic configuration.
- Adds transaction-encoding tests and updates deployment dependencies.
| File | Description |
|---|---|
deployment/go.mod |
Updates deployment dependencies. |
deployment/go.sum |
Refreshes dependency checksums. |
deployment/ccip/operation/registry.go |
Registers fee-aggregator operations. |
deployment/ccip/operation/fee_aggregator.go |
Generates Aptos MCMS transactions. |
deployment/ccip/operation/fee_aggregator_test.go |
Tests transaction encoding. |
deployment/ccip/adapters/init.go |
Registers the Aptos adapter. |
deployment/ccip/adapters/fee_aggregator.go |
Implements configuration and withdrawal sequences. |
deployment/ccip/adapters/fee_aggregator_test.go |
Tests adapter behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rodrigombsoares
approved these changes
Oct 7, 2026
JohnChangUK
approved these changes
Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://smartcontract-it.atlassian.net/browse/CCIP-13038