Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Missing-secret handling can silently disable authentication and required E2E coverage on trusted and merge-queue runs.
Review effort: Balanced
Findings: 2
Open (5)
What changed in this PR
Enables secret-free Dependabot and fork PR workflows while preserving authenticated CI for trusted runs.
Changes:
- Adds optional GATI/ECR authentication wrappers.
- Skips secret-dependent E2E jobs when credentials are unavailable.
- Makes coverage comments best-effort for read-only tokens.
| File | Description |
|---|---|
.github/workflows/test-smoke.yaml |
Gates secret-dependent smoke tests. |
.github/workflows/test-cl-smoke.yaml |
Gates Chainlink E2E and load tests. |
.github/workflows/test-services.yaml |
Uses optional local token setup. |
.github/workflows/test-evm-integration-module.yaml |
Uses optional local token setup. |
.github/workflows/test-devenv-module.yaml |
Uses optional local token setup. |
.github/workflows/test-deployment-module.yaml |
Uses optional local token setup. |
.github/workflows/test-coverage-report.yaml |
Tolerates PR-comment permission failures. |
.github/workflows/repo-hygiene.yaml |
Checks out before local token setup. |
.github/workflows/golangci-lint.yaml |
Checks out before local token setup. |
.github/actions/setup-github-token/action.yaml |
Adds a secret-aware GATI wrapper. |
.github/actions/run-load-test/action.yaml |
Makes load-test credentials optional. |
.github/actions/build-devenv-docker/action.yaml |
Allows unauthenticated public-image builds. |
.github/actions/aws-ecr-auth/action.yaml |
Skips ECR authentication without a role. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+116
to
+126
| env: | ||
| CCV_IAM_ROLE: ${{ secrets.CCV_IAM_ROLE }} | ||
| JD_REGISTRY: ${{ secrets.JD_REGISTRY }} | ||
| JD_IMAGE: ${{ secrets.JD_IMAGE }} | ||
| run: | | ||
| if [[ -n "$CCV_IAM_ROLE" && -n "$JD_REGISTRY" && -n "$JD_IMAGE" ]]; then | ||
| echo "e2e_runnable=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "e2e_runnable=false" >> "$GITHUB_OUTPUT" | ||
| echo "CI secrets unavailable; e2e jobs will be skipped." | ||
| fi |
Comment on lines
+36
to
+46
| env: | ||
| CCV_IAM_ROLE: ${{ secrets.CCV_IAM_ROLE }} | ||
| JD_REGISTRY: ${{ secrets.JD_REGISTRY }} | ||
| JD_IMAGE: ${{ secrets.JD_IMAGE }} | ||
| run: | | ||
| if [[ -n "$CCV_IAM_ROLE" && -n "$JD_REGISTRY" && -n "$JD_IMAGE" ]]; then | ||
| echo "e2e_runnable=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "e2e_runnable=false" >> "$GITHUB_OUTPUT" | ||
| echo "CI secrets unavailable; e2e-smoke jobs will be skipped." | ||
| fi |
Comment on lines
+6
to
+9
| role-to-assume: | ||
| description: 'IAM role to assume' | ||
| required: true | ||
| description: 'IAM role to assume. Empty skips authentication.' | ||
| required: false | ||
| default: '' |
Comment on lines
+42
to
+45
| # Empty inputs mean the run has no repo secrets (Dependabot or fork PR), so skip GATI. | ||
| - name: Setup GitHub Token | ||
| id: gati | ||
| if: inputs.aws-region != '' && inputs.aws-role-arn != '' && inputs.aws-lambda-url != '' |
Comment on lines
+19
to
+22
| jd-image: | ||
| description: 'JD Docker image' | ||
| required: true | ||
| description: 'JD Docker image. Empty (secretless runs) fails the load test; gate those jobs instead.' | ||
| required: false | ||
| default: '' |
|
Code coverage report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Checklist
changelogdirectory)