Repository navigation
adding batch size metric to durable emitter - #2445
Conversation
|
👋 patrickhuie19, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
📊 API Diff Results
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Only a minor test-coverage nit remains; no blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds OpenTelemetry instrumentation for durable-emitter insert batch sizes, including success/error labeling.
Changes:
- Registers and records the insert-batch size histogram.
- Adds metric export and coalescing coverage.
| File | Summary |
|---|---|
pkg/durableemitter/durable_emitter.go |
Records coalesced insert batch sizes. |
pkg/durableemitter/durable_emitter_test.go |
Tests metric recording and aggregation. |
pkg/durableemitter/durable_emitter_metrics.go |
Defines and registers the histogram metric. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Requires
Supports