Repository navigation
Conversation
Contributor
|
The flag was always set to true and never read; batch-size trimming in Outcome() is now unconditional. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bolekk
force-pushed
the
remove-limit-by-batch-size-flag
branch
from
October 7, 2026 05:08
1cbba88 to
93a4250
Compare
bolekk
marked this pull request as ready for review
October 7, 2026 05:30
pavel-raykov
approved these changes
Oct 7, 2026
jmank88
reviewed
Oct 7, 2026
| map<string, int64> requests = 2; | ||
| reserved 3; | ||
| bool limit_by_batch_size_flag = 4; | ||
| reserved 3, 4; |
Contributor
There was a problem hiding this comment.
nit/ is this more desirable than using [deprecated = true]? Because deprecation would be a bit safer
Contributor
Author
There was a problem hiding this comment.
I think there's no need to leave the old names around if nobody uses them. What makes it safer?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limit_by_batch_size_flagfield ondontime.Observationwas always set totrueand never read anywhere —Outcome()already trimsObservedDonTimesto batch size unconditionally.dontime.pb.go.Deployment Validation