Repository navigation
Remove deprecated EncodeExecutionID - #2448
Merged
Merged
Conversation
It has been fully replaced by GenerateExecutionIDWithTriggerIndex across callers; add test coverage for the replacement. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bolekk
force-pushed
the
remove_id_helper
branch
from
October 7, 2026 16:48
71de552 to
8f4496b
Compare
bolekk
marked this pull request as ready for review
October 7, 2026 16:48
Contributor
|
nolag
approved these changes
Oct 7, 2026
bolekk
enabled auto-merge
October 7, 2026 17:00
cedric-cordenier
approved these changes
Oct 7, 2026
jmank88
approved these changes
Oct 7, 2026
bolekk
disabled auto-merge
October 7, 2026 17:28
bolekk
enabled auto-merge
October 7, 2026 17:29
auto-merge was automatically disabled
October 7, 2026 17:40
Pull request was closed
bolekk
enabled auto-merge
October 7, 2026 17:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EncodeExecutionID, deprecated in favor ofGenerateExecutionIDWithTriggerIndex, now that callers (e.g. capabilities' HTTP trigger) have migrated off it.Test_GenerateExecutionIDWithTriggerIndexcovering determinism, trigger-index sensitivity, and input ordering.Deployment Validation
Library-only change with no runtime behavior for existing callers; confirm
go build/go testpass for downstream consumers (e.g. capabilities).🤖 Generated with Claude Code