Repository navigation
[CRE-6798] add ShardIndex to confidential relay request params - #2470
Merged
Merged
Conversation
Contributor
✅ API Diff Results -
|
bolekk
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Oct 14, 2026
Fan-out previously raced every configured shard and forwarded whichever reached quorum first, which is wrong here: secrets.get/capability.exec requests are not interchangeable across shards. The enclave now selects the shard via an explicit shard_index in request params (bumped to chainlink-common's new *int ShardIndex field, PR smartcontractkit/chainlink-common#2470); a missing value is rejected rather than defaulted to shard 0, since 0 is itself a valid shard. fanOutToNodes, evaluateShard (renamed from evaluateShards), and forwardAfterGrace now operate on the single resolved shard instead of looping over all of them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks done
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 3f9e970 | Previous: 0e9847f | Ratio |
|---|---|---|---|
BenchmarkKeystore_Sign/nop/out-of-process |
92362 ns/op |
27142 ns/op |
3.40 |
BenchmarkKeystore_Sign/hex/out-of-process |
92277 ns/op |
25753 ns/op |
3.58 |
BenchmarkKeystore_Sign/ed25519/out-of-process |
138719 ns/op |
45532 ns/op |
3.05 |
This comment was automatically generated by workflow using github-action-benchmark.
bolekk
force-pushed
the
cre-6798-confidential-relay-shard-index
branch
from
October 15, 2026 02:36
0cf17e1 to
23cb6a2
Compare
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> cre-6798: default ShardIndex to 0 when omitted Simplify from *int to plain int: an omitted shard_index now defaults to shard 0 instead of being rejected by the gateway. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bolekk
force-pushed
the
cre-6798-confidential-relay-shard-index
branch
from
October 15, 2026 02:37
23cb6a2 to
d10feea
Compare
bolekk
changed the title
bolekk
marked this pull request as ready for review
October 15, 2026 02:38
mchain0
approved these changes
Oct 15, 2026
vreff
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShardIndex intfield toSecretsRequestParamsandCapabilityRequestParamsso the enclave can tell the gateway which DON shard aconfidential.secrets.get/confidential.capability.executerequest must be routed to.Validate(the relay DON and enclave never read it).Companion to chainlink#23988, which consumes this field once released.
Deployment Validation
No runtime behavior change until a consumer reads the field; existing relay request/response flows are unaffected.
🤖 Generated with Claude Code