Skip to content

Billing: Confidential Workflow add execution_duration_ms - #469

Merged
DylanTinianov merged 3 commits into
mainfrom
CRE-6780-confidential-execution-duration
Oct 6, 2026
Merged

DylanTinianov merged 3 commits into
mainfrom
CRE-6780-confidential-execution-duration

Conversation

@DylanTinianov

@DylanTinianov DylanTinianov commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Adds optional int64 execution_duration_ms = 3 to ConfidentialWorkflowResponse (CRE-6780).

The enclave measures the wall-clock duration of the WASM execution and returns it so the workflow node can emit a cre:workflow:compute usage MeterRecord for confidential executions, the same resource type and unit as ordinary compute. optional so presence distinguishes an unavailable measurement from a measured zero; older enclaves leave it unset and the node emits nothing.

…owResponse

Enclave-measured wall-clock duration of the WASM execution in milliseconds,
so the workflow node can emit a cre:workflow:compute usage MeterRecord for
confidential executions (CRE-6780). Optional: presence distinguishes an
unavailable measurement from a measured zero, and older enclaves leave it
unset.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c1db255

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedOct 6, 2026, 5:58 PM

@DylanTinianov DylanTinianov changed the title confidentialworkflow: add execution_duration_ms to ConfidentialWorkflowResponse (CRE-6780) Billing: Confidential Workflow add execution_duration_ms Sep 29, 2026
@DylanTinianov
DylanTinianov requested a balanced review from Copilot September 29, 2026 18:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The additive optional field is backward-compatible and the embedded definition matches its source.

Review effort: Balanced
Findings: None

What changed in this PR

Adds an optional confidential workflow execution duration for downstream compute metering.

Changes:

  • Adds execution_duration_ms with presence semantics.
  • Synchronizes the embedded protobuf definition.
File Description
cre/​capabilities/​compute/​confidentialworkflow/​v1alpha/​client.proto Extends the response schema.
cre/​go/​installer/​pkg/​embedded_gen.go Updates the embedded schema copy.
Files not reviewed (1)
  • cre/go/installer/pkg/embedded_gen.go: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@DylanTinianov
DylanTinianov marked this pull request as ready for review October 6, 2026 16:22
@DylanTinianov
DylanTinianov requested review from a team as code owners October 6, 2026 16:23
@DylanTinianov
DylanTinianov enabled auto-merge (squash) October 6, 2026 16:43
@DylanTinianov
DylanTinianov disabled auto-merge October 6, 2026 16:55
@DylanTinianov
DylanTinianov enabled auto-merge (squash) October 6, 2026 16:55
@DylanTinianov
DylanTinianov disabled auto-merge October 6, 2026 17:55
@DylanTinianov
DylanTinianov enabled auto-merge (squash) October 6, 2026 17:56
@DylanTinianov
DylanTinianov merged commit b49d14c into main Oct 6, 2026
20 of 21 checks passed
@DylanTinianov
DylanTinianov deleted the CRE-6780-confidential-execution-duration branch October 6, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants