Skip to content

citool free disk space parameter - #2287

Merged
erikburt merged 2 commits into
mainfrom
feat/citool-free-disk-space
Nov 25, 2025
Merged

erikburt merged 2 commits into
mainfrom
feat/citool-free-disk-space

Conversation

@erikburt

@erikburt erikburt commented Nov 24, 2025 •

Copy link
Copy Markdown
Contributor

Changes

  • Add FreeDiskSpace to citool test configuration.

Motivation

  • We have been seeing disk space issues with some integration tests. Instead of enabling at the workflow level, enabling at the test level will save ~1 minute of runtime for each test that doesn't need to free up disk space.

DX-2386


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The change introduces a new configuration option FreeDiskSpace in the CITestConf struct to potentially control or monitor disk space usage during CI test runs. This addition could allow for more flexible and efficient test environment setups, possibly preventing issues related to disk space during testing.

What

  • tools/citool/cmd/types.go:
    • Added FreeDiskSpace bool field to the CITestConf struct. This allows specifying whether to free disk space before running tests.

@erikburt erikburt self-assigned this Nov 24, 2025
@erikburt
erikburt marked this pull request as ready for review November 24, 2025 23:31
@erikburt
erikburt requested a review from a team as a code owner November 24, 2025 23:31
Copilot AI review requested due to automatic review settings November 24, 2025 23:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a configurable FreeDiskSpace parameter to citool's test configuration, allowing individual tests to specify whether they need disk space freed before execution. This enables more granular control compared to workflow-level configuration, reducing unnecessary overhead for tests that don't require additional disk space.

  • Added a boolean field FreeDiskSpace to the CITestConf struct in citool

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@erikburt
erikburt enabled auto-merge (squash) November 25, 2025 20:35
@erikburt
erikburt merged commit 9dd7229 into main Nov 25, 2025
72 checks passed
@erikburt
erikburt deleted the feat/citool-free-disk-space branch November 25, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants