[DX-5482] Further adjust Alertgate - #2855
Merged
Merged
Conversation
… the selected alert set, combinable with both `--alerts` and label selection. A name that does not resolve is an error, and excluding the whole selection exits `2`. - Rename `--no-fail-fast` to `--fail-fast`, on by default. Pass `--fail-fast=false` to wait for the full window and its coverage proof. - When alerts are selected by labels, print each matched rule on its own line before the planned run time, so it is clear what was actually selected. - Round an observation window with a subsecond part up to the next whole second (by extending `to`), so a plan never reads `window 9m59.99445781s`. - Drop the warning that `transitionGrace` exceeds a quarter of the window; it was noise, not an actionable condition.
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
📊 API Diff Results
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Log mode can block reading a forbidden stdin exclusion, and exclusion read errors identify the wrong flag.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Enhances Alertgate selection controls, fail-fast configuration, and observation-window reporting.
Changes:
- Adds
--exclude-alertsfor named and label-based selections. - Renames the fail-fast flag and prints label-selected rules.
- Rounds subsecond windows and removes transition-grace warnings.
| File | Description |
|---|---|
grafana-alertcheck/README.md |
Documents alert exclusions. |
internal/gate/watch.go |
Applies exclusions during watch setup. |
internal/gate/watch_test.go |
Tests watch selection behavior. |
internal/gate/schedule.go |
Rounds windows and simplifies summaries. |
internal/gate/schedule_test.go |
Tests timing summaries and rounding. |
internal/gate/labels.go |
Implements exclusions and selection output. |
internal/gate/labels_test.go |
Tests exclusion resolution and output. |
internal/gate/check.go |
Integrates exclusions and rounded windows. |
internal/gate/check_test.go |
Tests updated check behavior. |
docs/reference/cli.md |
Updates the CLI reference. |
docs/index.md |
Updates introductory usage guidance. |
docs/how-alerts-are-evaluated.md |
Documents timing and fail-fast changes. |
docs/architecture.md |
Updates fail-fast architecture notes. |
cmd/watch.go |
Adds watch exclusion parsing. |
cmd/watch_test.go |
Tests conflicting stdin sources. |
cmd/common.go |
Registers the exclusion flag. |
cmd/check.go |
Adds exclusion and fail-fast CLI handling. |
cmd/check_test.go |
Tests changed check flags. |
.changeset/v0.1.8.md |
Records release changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sebawo
previously approved these changes
Oct 1, 2026
Tofel
enabled auto-merge (squash)
October 1, 2026 07:42
sebawo
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--exclude-alerts <file|->: an enumerated list subtracted from…the selected alert set, combinable with both--alertsand label selection. A name that does not resolve is an error, and excluding the whole selection exits2.Rename
--no-fail-fastto--fail-fast, on by default. Pass--fail-fast=falseto wait for the full window and its coverage proof.When alerts are selected by labels, print each matched rule on its own line before the planned run time, so it is clear what was actually selected.
Round an observation window with a subsecond part up to the next whole second (by extending
to), so a plan never readswindow 9m59.99445781s.Drop the warning that
transitionGraceexceeds a quarter of the window; it was noise, not an actionable condition.