Fix mock price feed deployment broadcasting - #47
Open
dkrithika wants to merge 1 commit into
Open
Conversation
dkrithika
requested review from
a team,
Nalon,
andrejrakic and
thodges-gh
as code owners
August 29, 2026 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mock price feed was deployed before
vm.startBroadcast()inPriceFeedConsumer.s.sol.As a result, the mock deployment was not broadcast to the target network, while
PriceFeedConsumerwas deployed with the mock's address. This causedgetPriceFeed()to return an address with no contract bytecode.Root Cause
The deployment script previously called
new MockV3Aggregator()beforevm.startBroadcast().This meant the mock was created during script execution but was not deployed as part of the broadcasted transactions.
Fix
Moved
vm.startBroadcast()before the mock price feed deployment so that both theMockV3AggregatorandPriceFeedConsumerdeployments are broadcast to the target network.Verification
The issue was reproduced by calling
getPriceFeed()and checking the returned address withcast code, which returned0x, indicating that no contract bytecode existed at that address.After the fix:
getPriceFeed()returned the deployed mock price feed address.cast codeon the returned address returned deployed contract bytecode.getLatestPrice()returned2000000000000000000000, corresponding to the expected2000e18mock price.forge testpassed.