Repository navigation
Dashboard: one error and retry component - #403
Merged
Merged
Conversation
Shared query recovery - Unify initial and background-refresh errors in the reserved-slot component. - Centralize bilingual retry copy and migrate dashboard and module call sites. Coverage - Update error, retry, and stable-layout tests for issue #393.
- #393: unify query loading and retry states in caller-sized compact rows and panels. - Migrate dashboard and module call sites while keeping bilingual retry copy centralized. - Verify toolbar, text-command editor, and module settings recovery at desktop and narrow widths.
- Shared query state - Consolidate list, panel, and settings retries in fixed LoadState variants. - Keep bilingual retry copy in the dashboard common catalog. - Stable layout - Fix ListToolbar wrapper layout and contain warnings feed errors. - Add responsive regression coverage for #393 with containment and pointer hit testing.
|
smb
added a commit
that referenced
this pull request
Oct 11, 2026
* 🚀 perf(dashboard): preload module chunks Dashboard loading - Memoize module panel, settings editor, and immediate action imports. - Preload enabled modules on idle and sidebar hover or focus. - Keep the current module view visible while a destination chunk resolves. Stable editor layouts - Reserve sized skeleton slots for module views and overlay element editors. - Cover preload and layout behavior with repeated browser specs. Issue reference - Implements #388. * 🐛 fix(dashboard): recoverable preloads, stable fallbacks - Recoverable module loading (#388) - Memoize panel, settings, action, and overlay editor imports, evict rejected promises, and recreate lazy views on retry. - Preload eligible chunks on sidebar hover/focus and idle using the shared visibility predicate. - Stable module layouts (#388) - Keep the reserved route height outside Suspense and reserve enough space for overlay editors. - Keep route transitions on the previous view until the new panel is ready. - Regression coverage (#388) - Verify failed imports recover and all lazy views/editors preserve their layout during delayed imports. - Measure responsive-hidden event cells as zero-size in the stable-layout assertion. * 🐛 fix(dashboard): recoverable preloads, stable fallbacks - Recoverable chunk loading (#388) - Evict rejected loader promises and recover failed lazy views from a fresh module map. - Keep lazy component identities stable across route Suspense retries. - Permission-aware preloading (#388) - Reuse the sidebar visibility filter for hover, focus, and idle preloads. - Stable panel layouts (#388) - Hold module and overlay editor reservations steady during delayed imports. - Cover every lazy module view and overlay editor with ten-repeat browser checks. * 🔧 chore(dashboard): align preloading with error component Dashboard error handling - Route failed lazy module imports through the shared error and retry component. - Reserve the error UI with the caller-selected panel-320 variant. Issue context - Completes #388 preloading alignment with #403 shared error handling. * 🐛 fix(dashboard): handle loader rejections, stable route test Loader promise recovery - Route synchronous throws and promise rejections through the eviction handler. - Preserve synchronous chunk loading and verify failure then success recovery. Navigation test stability - Hold the idle preload callback so pre-navigation assertions stay deterministic in CI. - Covers the #388 CI blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One error and retry component for the dashboard (epic #389).
QueryErrorState, theListToolbarstatus-row retry andLoadStatewithonRetryare merged into one component/pattern insrc/dashboard/uiwith a reserved slotCloses #393