Repository navigation
Chat voting: drop legacy preset columns - #408
Merged
Merged
Conversation
- 📊 Database: - Migration 0053 rebuilds chat_votes without preset and legacy_written; kind is NOT NULL - CHECK constraints use kind only; legacy kind trigger dropped - Approvals backed up and restored around the rebuild; indexes and panel revision triggers recreated - LATEST_SCHEMA_MIGRATION bumped to 0053 - 🧪 Tests: - Migration test for all six legacy presets, kind-only rows, approvals, NOT NULL and CHECKs - Schema fixtures and object counts updated Refs #407
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last slice of the chat voting rework (epic #397), after #399 and #401.
Merge only after #401 runs in production (0046 and 0052 applied, worker deployed). The production worker before #401 still writes
preset; with the column gone, starting a vote would fail.What changes
0053rebuildschat_voteswithoutpresetandlegacy_written;kindisNOT NULLand the CHECK constraints usekindonly.chat_votes_fill_legacy_kind_after_insert; indexes and panel revision triggers are recreated as in 0047.presetin memory, chat text and overlay stays.Deploy order
Production: apply
0053by hand, then deploy the worker. The #401 worker no longer touches the dropped columns, so applying the migration while it runs is safe.Verification
pnpm run checkgreen.Closes #407