Skip to content

Update application/json to multipart/form-data #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Agbaje Olalekan (olalekan-agbaje) wants to merge 1 commit into from
Closed

Update application/json to multipart/form-data #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs/v3/v3-replay-callback.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ paths:
callback URL (from the original verification or partner default)
is used.
content:
application/json:
multipart/form-data:
schema:
$ref: '#/components/schemas/ReplayCallbackRequest'
example:
Comment on lines 61 to 65

@prfectionist prfectionist Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Switching this simple structured body to multipart/form-data breaks existing JSON clients and loses type fidelity (multipart parts are transmitted as strings, so schema validation/coercion of callback_url becomes ambiguous). Since no binary/file upload is involved, keep application/json — or at minimum declare both media types so current integrations continue to work. [possible issue, importance: 6]

New proposed code: 
 content:
+  application/json:
+    schema:
+      $ref: '#/components/schemas/ReplayCallbackRequest'
+    example:
+      callback_url: 'https://partner.example.com/webhook'
   multipart/form-data:
     schema:
       $ref: '#/components/schemas/ReplayCallbackRequest'
     example:
       callback_url: 'https://partner.example.com/webhook'

Expand Down
Loading