js: Revert truncation of scaled ui amount - #1481
Merged
Merged
Conversation
#### Problem As discussed in solana-program#1480, the scaled ui amount was updated in the program and the JS clients, but that PR only affects the program. #### Summary of changes Update the JS clients to truncate once again.
|
Looks good One nit: this also reverts the formatUiAmountString part of #1345, so .toString() is back and small values render as 1e-9 where the program gives 0.000000001 (the 'inf' → 'Infinity' test flip is the same thing). |
Contributor
Author
|
Ah right, thanks, went back to using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As discussed in #1480, the scaled ui amount was updated in the program and the JS clients, but that PR only affects the program.
Summary of changes
Update the JS clients to truncate once again.
@cfkelly18 can you take a look?