Repository navigation
fix: a signed-out visitor to a startup form step is sent to login - #118
Merged
Merged
Conversation
Since #117 the hero only renders on the first screen, so a signed-out person opening /startup-registration?step=4 from the dashboard or an e-mail got an empty page. They now go to /auth and come back to the same step.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @thomgabriel's task in 10s —— View job Safe to merge. No findings. Checked:
|
The redirect dropped the utm parameters, so a click from an e-mail could not be measured for a signed-out person. They now ride on /auth and inside next.
|
Claude finished @thomgabriel's task in 11s —— View job Safe to merge. No findings. Checked: the redirect fires only when |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #117 the hero only renders on the first screen, so a signed-out person opening
/startup-registration?step=4got an empty page: no form, no login prompt. That is the link the feedback e-mail will use. They are now redirected to/auth?next=/startup-registration?step=4and come back to the same step. Without a step the page still shows the hero.Checked on a local server: step 4 signed out answers with the redirect, and the plain page and
?step=donestill render the hero.