Repository navigation
Verified CDK, Pulumi and SDK examples, with the server fixes they needed - #129
Merged
Merged
Conversation
- IAM: add the AWSCloudFormationReadOnlyAccess managed policy; allow 128-character policy, group and instance profile names; set aws:ResourceAccount for users and role sessions. - Lambda: support LoggingConfig (log group, format, levels) over the AWS API and in CloudFormation; add nodejs24.x, python3.14 and java25. - CloudFormation: DeleteChangeSet of a missing change set succeeds when the stack exists, as in AWS. - awsJson responses carry X-Amz-Crc32. - The self-signed certificate covers *.localhost and *.<public-host>. - Logs, metrics and the Lambda reaper only see this installation's containers.
Deploying homecloud with
|
| Latest commit: |
de53d85
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3ecea58d.homecloud.pages.dev |
| Branch Preview URL: | https://iac-examples.homecloud.pages.dev |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99, closes #100, closes #101
Verified commands
Each run against a fresh
homecloud serve(temp data dir, free ports) built from this branch, with credentials fromhomecloud aws-env.CDK (
examples/cdk/basic, CDK CLI 2.1145.0, aws-cdk-lib 2.273.0), server with--tls-self-signed:npx cdk bootstrap(default modern template, unchanged)npx cdk deploy --require-approval never, thenaws sqs send-message-> function logsorder receivedin its custom log group and the item lands in DynamoDB;aws s3 cpinto the bucketnpx cdk diff(change-set diff, no differences) and a secondcdk deploy(no changes)npx cdk destroy --forceafter emptying the versioned bucket; stack, function, queue, table, log group gonePulumi (
examples/pulumi/basic, Pulumi 3.268.0, @pulumi/aws 7.50.0,PULUMI_BACKEND_URL=file://...), over HTTP and over HTTPS:pulumi up, message round trip through SQS -> Lambda (nodejs24.x) -> DynamoDB,aws logs tailpulumi preview --expect-no-changes,pulumi refresh(no changes),pulumi preview --expect-no-changespulumi destroyleaves the account emptyaws:endpointsblock instead ofAWS_ENDPOINT_URL(needssts,s3controlandaws:skipCredentialsValidation, documented)SDKs (
examples/sdk): STS get-caller-identity, S3 create/put/get/delete, SQS create/send/receive/delete, DynamoDB create (waiter)/put/get/deletenode index.mjs), HTTP and HTTPSgo run .), HTTP and HTTPSmvn compile exec:java, Java 17), HTTP and HTTPS (trust store)Go tests run locally with Docker (
DOCKER_HOSTset): awsapi, iam, lambda, cfn, cloudwatch, runtime, dockertest, server all pass;go vet ./...clean.Server fixes found on the way
AWSCloudFormationReadOnlyAccessmanaged policy was missing (cdk bootstrap attaches it).aws:ResourceAccountcondition key is now set; the bootstrap publishing roles were denied their own staging bucket.LoggingConfig(log group, Text/JSON, levels) over the AWS API and CloudFormation (CDKlogGroup, Terraform/PulumiloggingConfig); it was silently ignored. JSON format setsAWS_LAMBDA_LOG_FORMAT/AWS_LAMBDA_LOG_LEVELfor the runtime.nodejs24.x,python3.14,java25.DeleteChangeSetof a nonexistent change set name succeeds when the stack exists (as in AWS);cdk difffell back to a template diff without it.X-Amz-Crc32; the Go v2 SDK logged a checksum warning on every DynamoDB call.--tls-self-signedcertificate covers*.localhost/*.<public-host>, so S3 Control (<account>.localhost, used by the Terraform/Pulumi providers) verifies over HTTPS; Pulumi hung retrying before.Not working / limits (documented)
aws:SecureTransport=false, and HomeCloud enforces it.autoDeleteObjects,BucketDeployment,logRetention) do not deploy; custom resources are not implemented.pages/index.html) is left for the release that ships these fixes.