Repository navigation
fix(tui/live): remove advertised session-picker key with no handler - #170
Merged
codeyevsky merged 3 commits intoOct 27, 2026
Merged
Conversation
The Live help table listed "s" as a session picker, but onKey never handled that key. Drop the misleading binding and add a regression test that every advertised help key has a handler. Closes solongate#148 Signed-off-by: Oscar <319719771+Oscar-Williams@users.noreply.github.com>
Rewrite TestLiveHelpAdvertisedKeysHaveHandlers to construct a KeyMsg for each advertised help token, call onKey, and require a Live state change relative to an unknown-key baseline. Drop the parallel handled map so a fake help row without a handler fails the test. Signed-off-by: Oscar <319719771+Oscar-Williams@users.noreply.github.com>
codeyevsky
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Live help table listed
sas a session picker, butonKeynever handled that key. Pressingsdid nothing; the help text was wrong. Commit5ba8641removed the session-picker handling and left this help row behind.Remove the misleading binding. Add a regression test that drives each advertised help key through
onKeyand checks the Live state actually changes (unlike an unknown key).Closes #148
How I checked it
New test against unpatched
main(aa46149, still listss):With the change, the same test passes. A temporary
{"z", "fake key with no handler"}help row (noonKeycase) fails the same way; removed after the check.Also:
gofmton the touched files,go vet ./...inpackages/tui,go test ./live/ -count=1, and./scripts/sg-unit-check.sh(all green).rgover the repo found no other "session picker" strings in help, docs, or README.