Skip to content

config: preserve execute bit when self-protection locks a file #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeyevsky merged 3 commits into from
Oct 27, 2026
Merged

config: preserve execute bit when self-protection locks a file #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c24164
Merge remote-tracking branch 'origin/main' into pr98-hamza
codeyevsky Oct 25, 2026
261dad4
config: preserve execute bit when self-protection locks a file
codeyevsky Oct 27, 2026
762ff4d
Merge remote-tracking branch 'origin/main' into pr98-hamza
codeyevsky Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/core/config/protect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@ func lockFile(file string) {
run("chflags", "uchg", file)
default:
run("chattr", "+i", file)
_ = os.Chmod(file, 0o400)
// 0o500, not 0o400: protectedTargets() includes the guard binary, and
// chattr commonly fails without CAP_LINUX_IMMUTABLE (containers,
// rootless), so this chmod is the fallback that actually runs. Keeping
// the execute bit matches the windows ACL above (grants RX) and the
// directory mode in protectpaths.go's LockPath.
_ = os.Chmod(file, 0o500)
}
}

Expand Down
8 changes: 4 additions & 4 deletions packages/core/config/protect_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ func TestLockFileThenUnlockFileRoundTrip(t *testing.T) {
if err != nil {
t.Fatal(err)
}
if info.Mode().Perm() != 0o400 {
t.Errorf("after lockFile, perm = %v, want 0400", info.Mode().Perm())
if info.Mode().Perm() != 0o500 {
t.Errorf("after lockFile, perm = %v, want 0500", info.Mode().Perm())
}

unlockFile(file)
Expand Down Expand Up @@ -90,8 +90,8 @@ func TestWriteProtectedFileOverLockedFileUnlocksRewritesAndRelocks(t *testing.T)
if err != nil {
t.Fatal(err)
}
if info.Mode().Perm() != 0o400 {
t.Errorf("perm after relock = %v, want 0400", info.Mode().Perm())
if info.Mode().Perm() != 0o500 {
t.Errorf("perm after relock = %v, want 0500", info.Mode().Perm())
}
}

Expand Down
Loading