Skip to content

fix(soloist): re-adopt a zone that becomes active again with no stream (end-of-track freeze) #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tobsch wants to merge 1 commit into from
Closed

fix(soloist): re-adopt a zone that becomes active again with no stream (end-of-track freeze) #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/adapters/inputs/spotify/soloist/soloistPlaybackService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,20 @@ export class SoloistPlaybackService {
return;
}

// Just became the active device again, but with nothing carrying our audio.
//
// The handoff that moved the account away tore this zone's stream down (finishTrack), and coming
// back is announced as a `device_changed`, which carries no `status` — so the `status === 'playing'`
// adopt below never fires on it. Mid-track that is harmless: the `playing` and `track_changed`
// events that follow re-adopt it. But when the switch back lands in the last seconds of a track,
// Soloist reaches the track's end before any of those arrive and then sends none, leaving the zone
// owner=`queue`, no stream, stuck at end-of-track while Soloist plays on into a pipe nobody reads.
// Re-adopting here reopens the pipe so playback is consumed again and advances. See #352.
if (event.type === 'device_changed' && !runner.stream) {
void this.adoptConnectPlayback(zoneId, event);
return;
}

// Both lists arrive together on `queue_changed`, unasked after every change. They are what
// tells a step backwards from a step forwards, and while the app owns the zone they are also
// the only account anyone here has of what is coming.
Expand Down
Loading