Princess: Eliminate abbreviation symbols from interpolants - #718
Open
daniel-raffler wants to merge 3 commits into
Open
daniel-raffler wants to merge 3 commits into
daniel-raffler wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this PR fixes an issue in Princess where internal abbreviation symbols could be leaked into interpolants. Since the symbols are only defined in the current
ProverEnvironmentthis could cause crashes when trying to use these interpolants later on in a differentProverEnvironmentThe work around in this PR is to simply eliminate abbreviation symbols from interpolants by replacing them with the full term