Add an API call to list available solvers for the current platform - #720
Open
daniel-raffler wants to merge 6 commits into
Open
daniel-raffler wants to merge 6 commits into
daniel-raffler wants to merge 6 commits into
Conversation
…, or dependencies are missing Set the property `javasmt.test.ignore-link-errors` to `false` to let the test fail. By default, tests are skipped when dependencies are missing
…ndencies in the tests
Several of the solvers require a newer version of libc and will fail to load with the current gitlab runner. We should revert this commit once the gitlab runner has been updated to a more recent version of Ubuntu
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this PR extends the JavaSMT API with a new call
Solvers.available()to list all solvers that are supported on the current OS and CPU architecture. The call works similarly to the existingSolvers.values()and can be used to iterate over all available solvers during testing. UnlikeSolvers.values()it skips over solvers that are not available on the platform, which helps to avoid failed tests due to missing libraries, when in reality the solver just isn't available for the testing platformThe PR also adds a new
antoption"ignoreLinkErrors"to decide if tests should fail if solver binaries are not installed, or when there are linking issues due to missing system libraries. By default allSolverBasedTestsare skipped if the solver binary can't be found, and only tests inSolverContextFactoryTestwill fail as a warning about the configuration issue. Setting the new option"ignoreLinkErrors"totruecauses the tests inSolverContextFactoryTestto also be skipped for the solver, while setting it tofalsemakes all tests fail if there are missing binaries or linking issuesAn example for how to use the
"ignoreLinkErrors"can be found in the updatedgitlab-ci.yml: Several of our solvers need a more recent version oflibcthan is available on the gitlab runner, and we're now setting"ignoreLinkErrors"totrueto skip tests that would otherwise fail when these solver can't be loaded