Repository navigation
fix: keep deleted blocks in document order - #48
Open
benmandrew wants to merge 1 commit into
Open
benmandrew wants to merge 1 commit into
benmandrew wants to merge 1 commit into
Conversation
process_replace emitted every unmatched old block before any new block, so a deleted equation after an edited paragraph appeared above it. Emit each deleted block just before the first new block that follows it in the old document.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_replaceemits every unmatched old block before any new block. A deleted display equation after an edited paragraph therefore appears above that paragraph. This reproduces it:Each deleted block is now emitted just before the first new block that came after it in the old document. Deleted blocks that nothing follows are still emitted last.