feat(web): make Sentry tracing and profiling opt-in - #1616
Merged
brendan-kellam merged 3 commits intoAug 25, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughSentry tracing now depends on ChangesSentry telemetry configuration
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOU-2011
Summary
SENTRY_TRACING_ENABLED=trueSENTRY_PROFILING_ENABLED=trueand require tracing to be enabledTesting
yarn workspace @sourcebot/web eslint src/sentry.server.config.ts src/sentry.edge.config.tsyarn workspace @sourcebot/web buildgit diff --checkNote
Low Risk
Observability toggles only; default behavior reduces tracing/profiling overhead with no change to error reporting when Sentry is configured.
Overview
Sentry performance tracing on the Node server and edge runtimes is now off unless
SENTRY_TRACING_ENABLED=true. When tracing is disabled,tracesSampleRateis no longer passed toSentry.init(previously it was always set with dev vs prod sampling).Server-side profiling (
nodeProfilingIntegration, session sampling, trace-linked lifecycle) is only registered when both tracing is enabled andSENTRY_PROFILING_ENABLED=true. Without those flags, Sentry still initializes for errors when DSN/env are set, but without trace or profile overhead..env.developmentdocuments the two new optional variables with defaults of"false".Reviewed by Cursor Bugbot for commit 3f6bd63. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit