Skip to content

fix(search): reconcile directory watcher state - #1143

Open
aaaaaandrew wants to merge 1 commit into
sourcegraph:mainfrom
aaaaaandrew:fix/watcher-reconciliation
Open

fix(search): reconcile directory watcher state#1143
aaaaaandrew wants to merge 1 commit into
sourcegraph:mainfrom
aaaaaandrew:fix/watcher-reconciliation

Conversation

@aaaaaandrew

Copy link
Copy Markdown
Contributor

Summary

  • record shard identity only after a successful load so transient failures retry
  • rescan after fsnotify registration to close the startup publication window
  • reconcile after watcher errors, including queue overflow
  • stop cleanly if fsnotify closes its channels

Test plan

  • go test ./...
  • go test -race ./search
  • go vet ./search
  • focused watcher tests repeated ten times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant