Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR extends the Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
2 issues found across 25 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/CMakeLists.txt">
<violation number="1" location="test/CMakeLists.txt:433">
P2: fail_rdf_invalid_instance is a runtime error-case test (exit 2) but, unlike its siblings this PR added (fail_rdf_mismatch_json, fail_rdf_resolution_json), it has no `--json` variant asserting the structured CTRF output. Consider adding a `fail_rdf_invalid_instance_json` script and registering it here to keep error reporting covered in both output formats.</violation>
</file>
<file name="test/test/fail_rdf_resolution.sh">
<violation number="1" location="test/test/fail_rdf_resolution.sh:37">
P3: The new text variant adds a second scenario ("No conflicting member") that its JSON counterpart fail_rdf_resolution_json.sh does not cover, so the paired text/JSON tests now diverge. Per the convention that error-case tests ship both text and --json variants covering the same scenarios, extend fail_rdf_resolution_json.sh with an equivalent pass case (or drop the extra case here) so coverage stays in sync and the structured JSON output is asserted for both paths.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| add_jsonschema_test_unix(test/fail_rdf_mismatch_json) | ||
| add_jsonschema_test_unix(test/fail_rdf_resolution) | ||
| add_jsonschema_test_unix(test/fail_rdf_resolution_json) | ||
| add_jsonschema_test_unix(test/fail_rdf_invalid_instance) |
There was a problem hiding this comment.
P2: fail_rdf_invalid_instance is a runtime error-case test (exit 2) but, unlike its siblings this PR added (fail_rdf_mismatch_json, fail_rdf_resolution_json), it has no --json variant asserting the structured CTRF output. Consider adding a fail_rdf_invalid_instance_json script and registering it here to keep error reporting covered in both output formats.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At test/CMakeLists.txt, line 433:
<comment>fail_rdf_invalid_instance is a runtime error-case test (exit 2) but, unlike its siblings this PR added (fail_rdf_mismatch_json, fail_rdf_resolution_json), it has no `--json` variant asserting the structured CTRF output. Consider adding a `fail_rdf_invalid_instance_json` script and registering it here to keep error reporting covered in both output formats.</comment>
<file context>
@@ -421,6 +421,16 @@ add_jsonschema_test_unix(test/fail_test_case_non_string_description)
+add_jsonschema_test_unix(test/fail_rdf_mismatch_json)
+add_jsonschema_test_unix(test/fail_rdf_resolution)
+add_jsonschema_test_unix(test/fail_rdf_resolution_json)
+add_jsonschema_test_unix(test/fail_rdf_invalid_instance)
add_jsonschema_test_unix(test/fail_true_resolve_fragment)
add_jsonschema_test_unix(test/fail_tests_empty)
</file context>
| "rdf": [] | ||
| }, | ||
| { | ||
| "description": "No conflicting member", |
There was a problem hiding this comment.
P3: The new text variant adds a second scenario ("No conflicting member") that its JSON counterpart fail_rdf_resolution_json.sh does not cover, so the paired text/JSON tests now diverge. Per the convention that error-case tests ship both text and --json variants covering the same scenarios, extend fail_rdf_resolution_json.sh with an equivalent pass case (or drop the extra case here) so coverage stays in sync and the structured JSON output is asserted for both paths.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At test/test/fail_rdf_resolution.sh, line 37:
<comment>The new text variant adds a second scenario ("No conflicting member") that its JSON counterpart fail_rdf_resolution_json.sh does not cover, so the paired text/JSON tests now diverge. Per the convention that error-case tests ship both text and --json variants covering the same scenarios, extend fail_rdf_resolution_json.sh with an equivalent pass case (or drop the extra case here) so coverage stays in sync and the structured JSON output is asserted for both paths.</comment>
<file context>
@@ -0,0 +1,65 @@
+ "rdf": []
+ },
+ {
+ "description": "No conflicting member",
+ "valid": true,
+ "data": {},
</file context>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti jv@jviotti.com